Fix: the banner render position not clamped to screen bounds#2258
Fix: the banner render position not clamped to screen bounds#2258Chang-zhi wants to merge 6 commits into
Conversation
Chang-zhi
commented
Jun 17, 2026
- Clamp PCX/SHP/CSF banner render position to the visible area after centering, preventing off-screen drawing
- Prevent a potential crash when a PCX banner exceeds the top screen edge
- Add corresponding documentation and credits
- Clamp PCX/SHP/CSF banner position to visible area after centering - Prevent potential crash when PCX banner exceeds the top screen edge - Add corresponding documentation and credits
|
This is some opinions from ststl-s, one of the original authors of the feature:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
I see your point, and I'm a bit worried. If a mapmaker turns the tag off, the crash would still happen when a PCX banner goes above the screen. I'm not sure that's acceptable. Unfortunately, I'm not familiar enough with reverse engineering to add a new hook that modifies the game's PCX rendering logic. |
From ststl-s:
|
- Add ClampToScreen boolean (defaults to true) to control whether PCX/SHP/CSF banners are clamped to the visible area - Update documentation, credits, and changelog
